codecov-commenter
commented
1 year ago Codecov Report
Base: 90.17% // Head: 90.22% // Increases project coverage by +0.05% :tada:
Coverage data is based on head (
2acd35a) compared to base (40a32ad). Patch coverage: 93.02% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== + Coverage 90.17% 90.22% +0.05% ========================================== Files 23 23 Lines 1882 1923 +41 ========================================== + Hits 1697 1735 +38 - Misses 185 188 +3 ``` | [Impacted Files](https://codecov.io/gh/wtbarnes/fiasco/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes) | Coverage Δ | | |---|---|---| | [fiasco/util/setup\_db.py](https://codecov.io/gh/wtbarnes/fiasco/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvc2V0dXBfZGIucHk=) | `64.83% <ø> (ø)` | | | [fiasco/io/sources/non\_ion\_sources.py](https://codecov.io/gh/wtbarnes/fiasco/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvL3NvdXJjZXMvbm9uX2lvbl9zb3VyY2VzLnB5) | `93.91% <92.68%> (-0.48%)` | :arrow_down: | | [fiasco/io/sources/tests/test\_sources.py](https://codecov.io/gh/wtbarnes/fiasco/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL2lvL3NvdXJjZXMvdGVzdHMvdGVzdF9zb3VyY2VzLnB5) | `100.00% <100.00%> (ø)` | | | [fiasco/util/util.py](https://codecov.io/gh/wtbarnes/fiasco/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes#diff-Zmlhc2NvL3V0aWwvdXRpbC5weQ==) | `70.42% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Will+Barnes):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This adds a parser (and HDF5 writer) for the various DEM files that are distributed with CHIANTI. Though these files can now be parsed and are added to the HDF5 database, it's not completely clear what the best way to expose this data is. This may be left to a separate PR.