Closed wtbarnes closed 1 year ago
Patch coverage: 100.00
% and project coverage change: -0.42
:warning:
Comparison is base (
c674d97
) 91.67% compared to head (37fb084
) 91.26%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Based on the test failures, it looks like the free-free and free-bound values have changed, likely due to the differences in how I'm interpolating the ioneq. The differences are surprisingly large which is worrying.
For Mg 12, when comparing to the equivalent IDL correction factors sent by Peter, the calculation here shows good agreement,
I've finally settled on using PchipInterpolator
to perform the cubic interpolation of the ionization fractions in log-space. This seems to be best solution for balancing smoothness and reducing oscillations. see plots of Fe V, VI, and XX ionization fractions below:
Comparing the correction factors as implemented here and those in CHIANTI IDL for Fe XX for T=10 MK and $n_e=10^{10}$ $\mathrm{cm}^{-3}$,
Fixes #24
This PR accomplishes two main things:
cilvl
andreclvl
files as described in Landi et al. (2006)A few remaining TODOs: