wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Fix `vectorize_where` bug and RTD config #241

Closed wtbarnes closed 5 months ago

wtbarnes commented 6 months ago

Fixes #239 Fixes #242

This also updates the pre-commit configuration to use Ruff and makes a few minor fixes to comply with the updated style configuration.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bb4670e) 91.96% compared to head (9ad9658) 92.55%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #241 +/- ## ========================================== + Coverage 91.96% 92.55% +0.59% ========================================== Files 23 23 Lines 2015 2015 ========================================== + Hits 1853 1865 +12 + Misses 162 150 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pep8speaks commented 5 months ago

Hello @wtbarnes! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 96:80: E501 line too long (81 > 79 characters)

Line 201:1: E302 expected 2 blank lines, found 1 Line 202:10: E231 missing whitespace after ',' Line 223:80: E501 line too long (81 > 79 characters)

Line 26:34: E225 missing whitespace around operator

Comment last updated at 2024-01-08 17:56:40 UTC