wtbarnes / fiasco

Python interface to the CHIANTI atomic database
http://fiasco.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
20 stars 15 forks source link

Revamp docs and add page on IDL-fiasco comparisons #259

Closed wtbarnes closed 4 months ago

wtbarnes commented 5 months ago

Fixes #255 Fixes #208 Fixes #215

Remaining TODOs

codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9d531da) 92.63% compared to head (10542c5) 92.30%.

Files Patch % Lines
fiasco/fiasco.py 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #259 +/- ## ========================================== - Coverage 92.63% 92.30% -0.34% ========================================== Files 38 38 Lines 2770 2780 +10 ========================================== Hits 2566 2566 - Misses 204 214 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wtbarnes commented 4 months ago

The last thing to do is make sure we have all the needed files for computing the rates (ionization and recombination) in the test file list. Currently, the compute rates are not showing up on the rendered docs because those files are missing from the test database.