The reference pixel is something we will want to change (even if only slightly) as the instrument design changes and as we measure more precisely the position of the pinholes. This should live on the new InstrumentDesign configuration class (as implemented in #22).
The main things we should decide is what the ideal interface is for changing these parameters. Right now, these are just implemented as a dictionary on Channel, but it seems clunky to have to implement this each time we want to change any pinhole configuration. Also, we probably want the number of pinholes to be flexible (i.e. we shouldn't just have a property for each because that would mean we'd need to add a property each time we added a pinhole) since we're experimenting with adding a second overlappogram (#20).
wtbarnes
commented
7 months ago
The reference pixel is something we will want to change (even if only slightly) as the instrument design changes and as we measure more precisely the position of the pinholes. This should live on the new
InstrumentDesignconfiguration class (as implemented in #22).The main things we should decide is what the ideal interface is for changing these parameters. Right now, these are just implemented as a dictionary on
Channel, but it seems clunky to have to implement this each time we want to change any pinhole configuration. Also, we probably want the number of pinholes to be flexible (i.e. we shouldn't just have a property for each because that would mean we'd need to add a property each time we added a pinhole) since we're experimenting with adding a second overlappogram (#20).