wtbarnes / mocksipipeline

Pipeline for producing synthetic images from the Multi-Order Spectral Imager (MOXSI)
MIT License
3 stars 1 forks source link

Should the filter configuration live on `InstrumentDesign`? #24

Closed wtbarnes closed 7 months ago

wtbarnes commented 9 months ago

Currently, the configuration of which filter belongs to which channel is hardcoded as a dictionary based on the channel name on the Channel class such that to change any of these, one has to subclass Channel. If we want to be able to easily iterate on the design of these different filters (e.g. as we have more accurate measurements of the filter thicknesses) we should add these configurations to the InstrumentDesign such that these parameters can be configured as we iterate on the design.

wtbarnes commented 7 months ago

Fixed by #25