search

wtbarnes / mocksipipeline

Pipeline for producing synthetic images from the Multi-Order Spectral Imager (MOXSI)
MIT License
3 stars 1 forks source link

Add aperture class for computing aperture area #27

Closed wtbarnes closed 7 months ago

wtbarnes commented 7 months ago

This PR adds a new abstract base class AbstractAperture as well as two additional concrete classes CircularAperture and SlotAperture. As a result, the Channel class now takes in an instance of this aperture class and it uses to compute the geometrical area such that the aperture can be any arbitrary shape. The OpticalDesign no longer takes in the pinhole diameter.

Additionally, this PR adds reprs for optical and instrument designs and also adds a method for combining instrument designs.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3f898e8) 63.40% compared to head (636420e) 64.64%.

Files Patch % Lines
mocksipipeline/instrument/design.py 66.66% 4 Missing :warning:
mocksipipeline/instrument/optics/aperture.py 86.20% 4 Missing :warning:
mocksipipeline/instrument/optics/design.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ========================================== + Coverage 63.40% 64.64% +1.24% ========================================== Files 13 14 +1 Lines 582 628 +46 ========================================== + Hits 369 406 +37 - Misses 213 222 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.