codecov-commenter
commented
7 months ago Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
fc57e1e) 66.85% compared to head (7f39073) 67.07%.
| Files | Patch % | Lines |
|---|---|---|
| mocksipipeline/instrument/design.py | 50.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #32 +/- ## ========================================== + Coverage 66.85% 67.07% +0.22% ========================================== Files 15 15 Lines 724 726 +2 ========================================== + Hits 484 487 +3 + Misses 240 239 -1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #28
This PR makes some changes to the pipeline to accommodate the addition of the second overlappogram. The main change is the move of the application of the PSF from the DEM/images to being done on the instrument cube just before projecting down to the detector.
There are still some major TODOs regarding the treatment of the PSF. Currently, the application of the PSF is still just being done with a Gaussian filter. In the slot case, the sigma in the vertical direction is $D{cc}/d$ times wider (where $D{cc}$ is the center-to-center distance of the slot). In reality, we should be building a kernel (using something like a tophat function) for the slot case.