wtbarnes / mocksipipeline

Pipeline for producing synthetic images from the Multi-Order Spectral Imager (MOXSI)
MIT License
3 stars 1 forks source link

Include "jitter" due to PSF and charge spreading #39

Closed jacobdparker closed 3 months ago

jacobdparker commented 5 months ago

Fixes #35 Fixes #40

This PR implements "jitter" in photon position in pixel space on the detector due to both 1) the wavelength-dependent PSF and 2) charge spreading.

This PR also

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 32.25806% with 168 lines in your changes missing coverage. Please review.

Project coverage is 55.56%. Comparing base (90fd01f) to head (b559431).

Files Patch % Lines
mocksipipeline/instrument/optics/aperture.py 23.47% 88 Missing :warning:
mocksipipeline/modeling.py 10.00% 54 Missing :warning:
mocksipipeline/instrument/design.py 10.71% 25 Missing :warning:
mocksipipeline/instrument/optics/response.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================== - Coverage 62.82% 55.56% -7.26% ========================================== Files 16 17 +1 Lines 780 1006 +226 ========================================== + Hits 490 559 +69 - Misses 290 447 +157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.