wtbarnes / mocksipipeline

Pipeline for producing synthetic images from the Multi-Order Spectral Imager (MOXSI)
MIT License
3 stars 1 forks source link

Change `Channel` inputs #6

Closed wtbarnes closed 1 year ago

wtbarnes commented 1 year ago

Currently, Channel objects are configured by specifying a filter and then using that to pull the information from the appropriate entry in the genx file. This is also then used as the "name" of the image.

However, it would be better to instead not assign a particular pinhole position a filter name but instead assign each pinhole a name (e.g. position 1, 2) and allow the filter to be variable.

The filter name should only determine where on the detector it is placed, not the filter used. Instead, the filter should be a separate input that can be used to select the filter transmission. For the pinholes, any filter name can be used to access the other properties as they are all the same.