search

wtchg-kwiatkowski / observatory-web

0 stars 0 forks source link

Genome Browser: After selecting the "Colour By:" option "Change", the "i" icon button appears, and clicking on it shows the selected "Change" option text with a colon suffixed (and nothing else). #165

Open leehart opened 6 years ago

leehart commented 6 years ago

HOME [tab] > Explore genomic data through the Viewer [heading] > View genome [button] > Variants [channel] > [cog button] > [channel configuration]

The same happens when selecting the "Gene Identifier" option.

benjeffery commented 6 years ago

The problem here is allowing the user to colour the variants by amino acid change. It makes no sense to do so and a legend for such a scheme would include a colour for every variant. One solution would be to exclude non-categorical, textual fields from the select.

leehart commented 6 years ago

I see. The spirit was simply along the lines of: there shouldn't be an introduction to a list that doesn't exist, i.e. "Change:" shouldn't appear, when nothing appears after it. The user would be none-the-wiser if that text simply didn't appear. However, the solution you mention, of excluding nonsensical options, sounds like it would solve both upstream and downstream issues. In terms of configuration, another option might be to only include explicitly specified fields, i.e. ones that make sense.

benjeffery commented 6 years ago

Looking further it is because there are no variants shown due to low zoom - so the legend is empty

benjeffery commented 6 years ago

I propose we fix this by making the legend say None shown instead of ""

leehart commented 6 years ago

Personally I'm not sure that Change: _None shown_ would be intuitive or clear.

It seems like a hidden/unexpected and problematic feature to hide legend information for items that happen to fall outside the current window / zoom level. (I guess it's either for the benefit of performance or brevity. Or maybe it's because the legend itself is derived from the data-in-view.) Maybe there is a way (perhaps with a checkbox option to toggle) to always show a complete legend, rather than a contextual one. Or maybe that's too computationally/programmatically inconvenient.

It also seems like a separate problem that, with the example, zooming out would see all variants coloured by amino-acid change, and apparently seizes up the browser. Maybe that could be prevented. I don't expect the user would mind if they were prevented from doing silly or hazardous things.