search

wtclarke / mrs_nifti_standard

The NIfTI-MRS data standard: specification, code, and example data.
Other
13 stars 5 forks source link

ENH: Propose metabolite cycling dim definition. #10

Closed wtclarke closed 3 months ago

wtclarke commented 3 months ago

Add DIM_METCYCLE to the dimensions definitions for storing metabolite cycled data .

@schorschinho, @HJZollner, @markmikkelsen, @martin3141 any comments on the naming or requests for additional information to go with this tag?

markmikkelsen commented 3 months ago

Hi @wtclarke,

Sounds good to me! My only thought regarding the DIM_ISIS tag is that it could apply to other multi-step experiments like MEGA-SPECIAL.

Mark

schorschinho commented 3 months ago

No complaints about DIM_METCYCLE. I'll pull the specifications file over into Osprey once you've merged it here.

Hi @wtclarke,

Sounds good to me! My only though regarding the DIM_ISIS tag is that it could apply to other multi-step experiments like MEGA-SPECIAL.

Mark

DIM_ISIS isn't new though? I'd assume that a MEGA-SPECIAL dataset will use DIM_ISIS and DIM_EDIT.

markmikkelsen commented 3 months ago

Oh, my mistake. I didn't pay attention clearly enough to the file changes.

martin3141 commented 3 months ago

Yup, all good from my perspective.

wtclarke commented 3 months ago

Thanks all.

schorschinho commented 3 months ago

Now also in Osprey https://github.com/schorschinho/osprey/commit/77f45e61f74197a4ba5777bb75cc16aac93d5423