search

wtclarke / nifti_mrs_tools

Software tools for the NIfTI-MRS data format
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Exclude contents of subdirectories of the standard submodule #25

Closed musicinmybrain closed 5 months ago

musicinmybrain commented 5 months ago

Fixes #24.

This is perhaps not the most elegant fix, but it appears to be effective, correctly excluding nifti_mrs/standard/explanatory_doc/conf.py from the sdist and therefore also from the wheels, as test-built with python3 -m build.

Note that setuptools is recalcitrant (https://github.com/pypa/setuptools/issues/3260) about this sort of thing.

(If the sdist does contain nifti_mrs/standard/explanatory_doc/conf.py, as when this PR is applied as a patch to the existing 1.2.0 sdist, then this PR doesn’t keep the wheel from containing it too.)

wtclarke commented 5 months ago

Thanks for this. I spotted that this file was included, but then forgot to do anything about it.