search

wtclarke / pymapvbvd

Python port of mapVBVD
MIT License
44 stars 25 forks source link

Various performance enhancements #31

Closed alexcraven closed 1 year ago

alexcraven commented 1 year ago

A handful of adjustments for more efficient reading of the headers (see individual commit messages for somewhat more detail)

wtclarke commented 1 year ago

@alexcraven Thanks for getting these into a PR. Could you just handle the couple of linting issues shown up in the tests? Copied here incase you can't see them:

image
alexcraven commented 1 year ago

Sure; should be corrected now. I also noticed that read_twix_hdr could loop indefinitely on certain corrupt input files, so added some error checking there in the latest commit.

wtclarke commented 1 year ago

@alexcraven Thanks, I've merged this now that all tests have passed. I'll deal with a couple of other minor issues and get this pushed out in a new version this afternoon (hopefully).