wtforms / flask-wtf

Simple integration of Flask and WTForms, including CSRF, file upload and Recaptcha integration.
https://flask-wtf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.46k stars 310 forks source link

Add `MultipleFileField` and support validating multiple files #556

Closed greyli closed 11 months ago

greyli commented 1 year ago

Continue #338

fixes #337 fixes #393

Checklist:

greyli commented 1 year ago

The failed style check is handled in #557.

greyli commented 1 year ago

Not sure why the warnings from flask-babel are treated as errors: https://github.com/wtforms/flask-wtf/actions/runs/5623535426/job/15238419433?pr=556#step:6:129

azmeuk commented 1 year ago

This can be useful to force us to fix the deprecation warnings emitted by other libraries.

However for this one there is not much that can be done on our side since the warning is emitted because of flask-babel: https://github.com/python-babel/flask-babel/pull/230 cc @tktech is the PR there ok to you?

Anyways, I checked your branch (with the flask-babel patch) and this looks all good to me :ok_hand:

azmeuk commented 1 year ago

@greyli you are maintainer, do you want to merge this PR or do you need other pairs of eyes to review it?

greyli commented 1 year ago

Yes, I do want to merge this. Just went through all the changes again and fixed a typo in the docs.

azmeuk commented 11 months ago

@greyli Do you think it this is ready to merge now? Do you want me to merge it and cut a release?

greyli commented 11 months ago

@greyli Do you think it this is ready to merge now? Do you want me to merge it and cut a release?

I think so. Thanks!