wtg / Shuttle-Tracker-SwiftUI

Rensselaer campus shuttle tracker
https://shuttletracker.app
Mozilla Public License 2.0
9 stars 2 forks source link

Dynamic bus colors in the info view with color-blind mode #115

Closed JohnF1103 closed 1 year ago

JohnF1103 commented 1 year ago

…mode

tommytrg297 commented 1 year ago

This method is different from the one used in right below : You must be within (self.maximumStopDistance) meter(self.maximumStopDistance == 1 ? "" : "s") of a stop to board a bus." Maybe use self.colorblindMode ? "The scope icon indicates high-quality location data." : "Green buses indicate high-quality location data." directly instead of declaring a separate variable

Gerzer commented 1 year ago

This method is different from the one used in right below : You must be within (self.maximumStopDistance) meter(self.maximumStopDistance == 1 ? "" : "s") of a stop to board a bus." Maybe use self.colorblindMode ? "The scope icon indicates high-quality location data." : "Green buses indicate high-quality location data." directly instead of declaring a separate variable

@TruongTommy99 Would you mind adding this comment in a proper code review? Here’s how:

  1. Select the “Files changed” tab
  2. Hover your cursor over the relevant line of code
  3. Click the blue “+” button
  4. Type your comment
  5. Click “Start a review”
  6. Repeat steps 2–5 for each comment that you want to add
  7. Click “Review changes” in the top-right corner
  8. Type a summary comment (optional)
  9. Select “Request changes”
  10. Click “Submit review”

This process makes it clear to the person who opened the pull request (in this case, @JohnF1103) exactly what still needs to be changed. Thanks!