wtg / shuttletracker

🚐 Shuttle tracking for RPI.
https://shuttles.rpi.edu
GNU Affero General Public License v3.0
46 stars 53 forks source link

TV Panel Scaffold #260

Open josephom12 opened 5 years ago

josephom12 commented 5 years ago

This PR includes routing for the TV panel at /tvpanel and base components for tvpanel, Map, Header, ETAs and News.

Builds the front-end scaffold to implement:

Note: I'm unsure on how to fix those CI errors.

codecov[bot] commented 5 years ago

Codecov Report

Merging #260 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #260      +/-   ##
=========================================
+ Coverage   37.45%   37.5%   +0.04%     
=========================================
  Files          17      17              
  Lines        1559    1560       +1     
=========================================
+ Hits          584     585       +1     
  Misses        911     911              
  Partials       64      64
Impacted Files Coverage Δ
api/api.go 80.73% <100%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af012aa...8a00a6b. Read the comment docs.

josephom12 commented 5 years ago

image

Don't really like the redundant title bar, please try other configurations of putting "Shuttle Tracker" and "shuttles.rpi.edu" on the page

Otherwise, good starting design with the side bar

image

Banner on the bottom

quuu commented 5 years ago

image Don't really like the redundant title bar, please try other configurations of putting "Shuttle Tracker" and "shuttles.rpi.edu" on the page Otherwise, good starting design with the side bar

image

Banner on the bottom

When i said redundant, I meant how you have both "Shuttle Tracker" and the URL both in the same bar

josephom12 commented 5 years ago

image Don't really like the redundant title bar, please try other configurations of putting "Shuttle Tracker" and "shuttles.rpi.edu" on the page Otherwise, good starting design with the side bar

image Banner on the bottom

When i said redundant, I meant how you have both "Shuttle Tracker" and the URL both in the same bar

LOOOL oh gotcha!

Here's another variation just in case it appeals to you before I start moving the names.

image

quuu commented 5 years ago

LOOOL oh gotcha!

Here's another variation just in case it appeals to you before I start moving the names.

image

Leave it for now, build out the rest of the UI and then we'll ask others what they think of it as well.

josephom12 commented 4 years ago

Looking at the console of the TV Panel, I see an error that says: image

When I go to localhost:8080/fusion, I get the error: image

Did I miss something or is this error popping up because I'm running it on my machine? I don't seem to get these errors when I run localhost:8080 though.. thoughts?

@quuu @IncognitoCactus @evanlazaro

josephom12 commented 4 years ago

I have a question! @evanlazaro @quuu @IncognitoCactus

Is using fusion necessary for the TV panel? I'm not exactly sure what fusion does but does it have any impact on the main application? (Besides the bus-button)

If anyone knows what exactly fusion/websocket does in this application, please let me know!