codecov[bot]
commented
4 years ago Codecov Report
Merging #283 into master will decrease coverage by
0.20%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 37.29% 37.09% -0.21%
==========================================
Files 17 17
Lines 1566 1561 -5
==========================================
- Hits 584 579 -5
+ Misses 917 915 -2
- Partials 65 67 +2 | Impacted Files | Coverage Δ | |
|---|---|---|
| postgres/stop.go | 25.92% <ø> (ø) |
|
| postgres/location.go | 60.66% <0.00%> (-3.34%) |
:arrow_down: |
| updater/updater.go | 4.66% <0.00%> (+0.11%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5aaa66a...73b3f5d. Read the comment docs.
Wolfizen
**_DO NOT MERGE UNTIL TESTED_**This PR contains all commits from #276 and #279. After the revert in #278, we need to include the #276 commits into this PR so when we are ready to merge, we re-merge the original work.
Likely this PR will need to be merged by the Fall 2020 team. I'm available to answer any of your questions: wolfizen@wolfizen.net
What
This PR adds a dark theme to the main app. It is configurable via the settings page. This theme affects everything under
App.vue, so no admin page dark mode. The dark mode has three options: On, Off, At Night. The at night option turns dark mode on during the hours of night. The actual sunrise and sunset times at RPI are used to decide which hours are night. This mode uses Vue reactive variables, so it will change even on long-running sessions like a TV panel.How
Every color in the app stylesheet is replaced with a CSS variable reference. The master theme variables are switched to either light or dark upon the user changing the theme.
theme.tshas a detailed documentation of this behavior. The map tiles are updated via a Vue watcher on current theme. I chose Carto's Dark Matter tiles for the dark theme.