search

wtimme / OSM-Completionist

⛔️ DEPRECATED iOS companion app for OpenStreetMap that allows contributors to complete missing information
ISC License
18 stars 4 forks source link

Add building:part to preset fields #32

Closed LucasLarson closed 4 years ago

LucasLarson commented 4 years ago

Adding a frequently used key to the autocomplete presets

wtimme commented 4 years ago

Thanks for your contribution!

I don't have a strong opinion against merging this. The only thing that I am contemplating is whether this preset (that no doubt adds some value for you) might get overwritten the next time we sync this JSON file with the one from iD.

From the Git history of that file it looks like the guys over at the iD repository are pretty quick with merging, so it might be more sustainable to try to get them to add it to their fields.json file.

What do you think - should we take the risk or rather ask them to add this to the "official" list of presets?

LucasLarson commented 4 years ago

Wow — I didn’t know GoMap or Completionist well enough to realize we weren’t generating that part of it ourselves. I should definitely propose this at iD instead. Thank you!

I couldn’t read from the repo where this ever gets updated though… does it?

wtimme commented 4 years ago

You're correct, it only gets updated manually, which hasn't happened in a while. I've created an issue (#34) to change this.

Since that is the case, I think we can merge this without problems for now. Thanks for your contribution!

wtimme commented 4 years ago

Hey LucasLarson,

I just merged the latest changes from bryceco/GoMap, I had a merge conflict in the presets.json file. With bryceco/GoMap#260, @bryceco updated the presets.json file, and the format of the file had changed completely.

I resolved the merge conflict in a way that includes your changes, but maybe it'd be a good idea to contact the iD maintainers with your preset suggestion. Just FYI. :)