search

wtimme / OSM-Completionist

⛔️ DEPRECATED iOS companion app for OpenStreetMap that allows contributors to complete missing information
ISC License
18 stars 4 forks source link

Automatically update data (like presets.json) from iD when releasing a new version #34

Closed wtimme closed 4 years ago

wtimme commented 4 years ago

Is your feature request related to a problem? Please describe. At the moment, the data from iD that our app incorporates is a bit dusted, since it used to be updated manually by hand. If we wanted to update them, it would require quite some manual work.

Describe the solution you'd like When releasing a new version, the information from the iD repository (e. g. presets.json) should be copied into OSM-Completionist automatically.

Describe alternatives you've considered We could continue to do this manually, but as pointed out, that requires time and effort.

Additional context This was brought up in #32.

bryceco commented 4 years ago

Note that often when the presets change it will also require code changes (sometimes significant) to support new functionality or to prevent the app from crashing.

wtimme commented 4 years ago

Thanks for raising this concern, Bryce!

Before implementing a mechanism to automatically update these JSON files from iD, I would like us to create integration tests first. When run, they should make sure that the JSON can be properly parsed and doesn't result in any errors.

tordans commented 4 years ago

Related: https://github.com/bryceco/GoMap/issues/119

wtimme commented 4 years ago

This is a good idea, but it should be implemented upstream, in bryceco/GoMap.