search

wtimme / OSM-Completionist

⛔️ DEPRECATED iOS companion app for OpenStreetMap that allows contributors to complete missing information
ISC License
18 stars 4 forks source link

Move rendering of Notes to dedicated layer #52

Open wtimme opened 4 years ago

wtimme commented 4 years ago

User Story

As a developer, I want the fetching and rendering of the notes to be moved out of MapView, so that MapView has less responsibilities

Acceptance Criterias

Unhappy Cases

If these changes were not merged back to (bryceco/GoMap), the chances of merge conflicts increase.

@bryceco, is there anything I can do to increaes the chance that this will get merged also to your main repository?

Additional context

This is some preparation for #28. When we use protocols, we might be able to display quests the same way.

bryceco commented 4 years ago

I’m fine with a change like this as long as it doesn’t change the existing behavior. I suspect it’s going to cause issues similar to #62, but if that is addressed I’ll accept the pull.