wting / autojump

A cd command that learns - easily navigate directories from the command line
Other
16.19k stars 705 forks source link

Error flushing to file when no space is left on the device #92

Closed tnorth closed 12 years ago

tnorth commented 12 years ago

This is a rather obvious problem, when the device is full, autojump 19 can't write and flush() to the temporary device. This is a minor issue, but it has been reported by fred here: https://bugzilla.redhat.com/show_bug.cgi?id=770572

The perfect behaviour would be to warn the user instead of crashing. But I would understand if the bug is closed WONTFIX.

backtrace: :autojump:89:save:IOError: [Errno 28] No space left on device : :Traceback (most recent call last): : File "/usr/bin/autojump", line 314, in : success=shell_utility() : File "/usr/bin/autojump", line 227, in shell_utility : save(path_dict, dic_file) : File "/usr/bin/autojump", line 89, in save : temp.flush() :IOError: [Errno 28] No space left on device : :Local variables in innermost frame: :path_dict: {u'/usr/share/gnome-shell/theme': 2.0, u'/lib/systemd': 3.0, u'/home/fred/openwrt': 45.0, u'/home/fred/braid': 2.0, u'/usr/lib64': 3.0, u'/etc/sysconfig/network-scripts': 8.0, u'/etc/systemd/user': 6.0, u'/etc/sysconfig/console': 2.0, u'/home/fred/openwrt/package': 7.0, u'/usr/local/share': 8.0, u'/home/fred/jamestown': 2.0, u'/usr/local/share/applications': 4.0, u'/home/fred/voxatron': 10.0, u'/home/fred/voxatron2/voxatron': 13.0, u'/home/fred/pulseaudio': 4.0, u'/usr/share/gnome-shell': 4.0, u'/home/fred/T\xe9l\xe9chargements': 74.0, u'/home/fred/foobar-sample': 3.0, u'/etc/rc.d/init.d': 2.0, u'/home/fred/systemtap': 53.0, u'/home/fred/gnome-shell-extensions': 13.0, u'/usr/share/gnome-shell/extensions': 8.0, u'/etc/systemd/system/multi-user.target.wants': 2.0, u'/etc/systemd/system': 14.0, u'/etc': 3.0, u'/home/fred/VVVVVV': 5.0, u'/home/fred/.ssh': 7.0, u'/home/fred/Machinarium': 12.0, u'/home/fred/bit.trip.runner-1.0': 2.0, u'/usr/share/gnome-shell/extensions/user-theme@gnome-shell-extensions.gnome.org': 7.0, u'/home/fred/gnome-shell-extensions/extensions': 4.0, u'/lib/systemd/system': 5.0, u'/etc/sysconfig': 15.0, u'/home/fred/atomzombiesmasher': 6.0, u'/etc/systemd/system/basic.target.wants': 3.0, u'/home/fred/.pulse': 2.0, u'/etc/systemd': 11.0, u'/usr/share/systemtap': 2.0, u'/home/fred/backfire': 10.0, u'/home/fred/bit.trip.runner-1.0/bit.trip.runner': 2.0, u'/home/fred/Vid\xe9os': 2.0, u'/usr/lib64/pulse-0.9.23': 3.0, u'/etc/systemd/system/graphical.target.wants': 2.0, u'/home/fred/CaveStory+': 4.0} :path: u'/etc/systemd/system/graphical.target.wants' :temp: <open file '', mode 'w+b' at 0x7fe51c02bed0> :weight: 2.0 :dic_file: '/home/fred/.local/share/autojump/autojump.txt'

joelthelion commented 12 years ago

Hi Thibault,

It should be solved now. Can you check?

wting commented 12 years ago

@tnorth: I've fixed this issue in faf0854, and commented on the RedHat bug as well.

I'm closing this issue due to inactivity. If the behavior reappears please let us know (preferably here, but I'm subscribed to the RedHat bug report as well).