wting / python-graph

Automatically exported from code.google.com/p/python-graph
Other
5 stars 4 forks source link

Code review request: Critical Path and Transitive Edges algorithms #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
- added 2 new algorithms

When reviewing my code changes, please focus on:
- 2 new functions need some testing:
* digraph.critical_path
* digraph.transitive_edges

- see examples/ex_critical.py for a simple dev example

Original issue reported on code.google.com by tomaz.ko...@gmail.com on 27 Mar 2009 at 9:12

GoogleCodeExporter commented 9 years ago
Sorry for the late reply, Tomaz. I'm a bit busy now, but I'll make an effort to
review your commit by Sunday.

Thanks!

Original comment by pmatiello on 2 Apr 2009 at 12:14

GoogleCodeExporter commented 9 years ago
It's my pleasure Pedro!

Hope I'll find some spare time to provide some unit tests.

Original comment by tomaz.ko...@gmail.com on 2 Apr 2009 at 6:36

GoogleCodeExporter commented 9 years ago
Set review issue status to: Fixed

Original comment by pmatiello on 6 Apr 2009 at 2:49

GoogleCodeExporter commented 9 years ago
Will you merge this branch into the trunk? Or provide it as a new release? 

Original comment by tomaz.ko...@gmail.com on 6 Apr 2009 at 4:49

GoogleCodeExporter commented 9 years ago
We'll merge it into the trunk for now and it will go out with the next release 
(by
the end of this month, I hope so).

Original comment by pmatiello on 6 Apr 2009 at 5:08

GoogleCodeExporter commented 9 years ago
Merged. I also added credits to you in the README file.

Do you need any help with the unit-tests?

Original comment by pmatiello on 12 Apr 2009 at 10:16

GoogleCodeExporter commented 9 years ago
Looks good!

I'm very busy at the moment, so I'll try to commit the promised unit-tests as 
soon as
possible. 

Original comment by tomaz.ko...@gmail.com on 12 Apr 2009 at 11:34