bdist_rpm fails because of COPYING and Changelog missing from python_graph.egg-info/SOURCES.txt

wting / python-graph

Automatically exported from code.google.com/p/python-graph

Other

5 stars 4 forks source link

bdist_rpm fails because of COPYING and Changelog missing from python_graph.egg-info/SOURCES.txt #34

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Fedora 11
2. python setup.py bdist_rpm

What is the expected output? What do you see instead?

Expects rpm to be found in dist/

BUT it fails.

Adding 
COPYING
Changelog
to python_graph.egg-info/SOURCES.txt makes it work correctly.

Alternatively they can be removed from datafiles in setup.py.

What version of the product are you using? On what operating system?

python-graph-1.6.1.tar.bz2 on Fedora 11

Original issue reported on code.google.com by kiile...@gmail.com on 20 Jul 2009 at 2:59

GoogleCodeExporter commented 9 years ago

Accepted.

Original comment by pmatiello on 20 Jul 2009 at 6:31

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

The python_graph.egg-info folder is generated by the compile process. I suspect 
that
there is probably some metadata which needs to be added to the setup script in 
order
to ensure that these files are added.

But stricly speaking, I'm not 100% certain that they are required for the RPM
standard... and I'm not convinced that this is the best way to package up as an 
RPM. 

kiilerix, can you let me know if you can do "bdist_egg" to make a regular .egg 
file.
Is bdist_rpm the only kind of build which is failing for you?

Can you tell me which python & setuptools you have installed.

Original comment by salimfadhley@gmail.com on 20 Jul 2009 at 7:57

GoogleCodeExporter commented 9 years ago

On my Ubuntu PC, I just installed "alien" (RPM support) and did:

python setup.py bdist_rpm

The end result was an OK looking RPM (I didnt bother installing it because I'm 
on
Ubuntu), but I suspect that the bug might be more to do with the user's Python +
Setuptools config than a fault with our setup script.

Sal

Original comment by salimfadhley@gmail.com on 20 Jul 2009 at 8:02

GoogleCodeExporter commented 9 years ago

I have the same setup (Fedora 11). I can build eggs but not rpms. I suspect it's
Fedora's fault, but I'll investigate it more.

Original comment by pmatiello on 20 Jul 2009 at 8:10

GoogleCodeExporter commented 9 years ago

Yes, bdist_egg works fine.

You are right, the "missing" files are not needed by any RPM standard.

The problem is that bdist_rpm first creates a tar.gz file by running what 
corresponds
to "setup.py sdist". That tar ball contains only what is referenced from 
SOURCES.txt
- it contains README but no Changelog or COPYING. The spec extracts that tar 
ball and
runs "setup.py install" - and it will fail because there is no Changelog or 
COPYING.

Original comment by kiile...@gmail.com on 20 Jul 2009 at 8:20

GoogleCodeExporter commented 9 years ago

It seems to be working fine under Fedora 12.

Original comment by pmatiello on 12 Jan 2010 at 12:42

GoogleCodeExporter commented 9 years ago

Confirmed. 1.6.2 failed too, but 1.6.3 works (under Fedora 12).

Original comment by kiile...@gmail.com on 12 Jan 2010 at 1:00

GoogleCodeExporter commented 9 years ago

I'm closing the issue then.

Thank you for you report.

Original comment by pmatiello on 12 Jan 2010 at 1:34

Changed state: Fixed