wtjiang98 / PSGAN

PyTorch code for "PSGAN: Pose and Expression Robust Spatial-Aware GAN for Customizable Makeup Transfer" (CVPR 2020 Oral)
MIT License
734 stars 147 forks source link

Histogram loss on lip and eyes #29

Closed CelineWang1027 closed 3 years ago

CelineWang1027 commented 3 years ago

Hi, thanks for your wonderful works. When I am trying to implement your code, I found that the histogram loss on lip and eyes are always 0. This issue leads to inaccuracy on makeup transfer of lipstick and eyeshadow. I tried but failed to find out the possible problem in codes. Can you do me a favor? I did not change codes in calculating histogram loss.

G-A-eye-loss-his G-A-lip-loss-his

Hong-Bo commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

YongshengDong commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

Have you solved it?

Hong-Bo commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

Have you solved it?

Please simply just do not load the pretrained weights

YongshengDong commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

Have you solved it?

Please simply just do not load the pretrained weights

Hi, I train it without the pretrained weights, however the histogram loss on lip and eyes are still zero

Hong-Bo commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

Have you solved it?

Please simply just do not load the pretrained weights

Hi, I train it without the pretrained weights, however the histogram loss on lip and eyes are still zero

I solved this problem three weeks ago and could not remember details. Despite not loading the pretrained weights, there's something wrong about the makeup loss as my memory rewinds, a problem that I forgot to write down. I tackled the problem by visualizing the image results during and after Histogram matching. I bet you could solve the problem via visualizing intermediate results too.

YongshengDong commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

Have you solved it?

Please simply just do not load the pretrained weights

Hi, I train it without the pretrained weights, however the histogram loss on lip and eyes are still zero

I solved this problem three weeks ago and could not remember details. Despite not loading the pretrained weights, there's something wrong about the makeup loss as my memory rewinds, a problem that I forgot to write down. I tackled the problem by visualizing the image results during and after Histogram matching. I bet you could solve the problem via visualizing intermediate results too.

Could you share the makeup loss after you fixed it? Actually, I visualized the image after Histogram matching and found the result which before and after histogram_matching was same! I am puzzled about it, do you have any ideas?

Hong-Bo commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

Have you solved it?

Please simply just do not load the pretrained weights

Hi, I train it without the pretrained weights, however the histogram loss on lip and eyes are still zero

I solved this problem three weeks ago and could not remember details. Despite not loading the pretrained weights, there's something wrong about the makeup loss as my memory rewinds, a problem that I forgot to write down. I tackled the problem by visualizing the image results during and after Histogram matching. I bet you could solve the problem via visualizing intermediate results too.

Could you share the makeup loss after you fixed it? Actually, I visualized the image after Histogram matching and found the result which before and after histogram_matching was same! I am puzzled about it, do you have any ideas?

I made tons of modification locally. It's a little difficult for me to tell which modification solved the problem. Nonetheless, a cross comparison with the HEAD might point answer to line 26 and 29 in HistogramLoss class. You can try to remove the unsqueeze action in these two lines.

YongshengDong commented 3 years ago

Encountered the same issue. Did you solve it? Thanks

Have you solved it?

Please simply just do not load the pretrained weights

Hi, I train it without the pretrained weights, however the histogram loss on lip and eyes are still zero

I solved this problem three weeks ago and could not remember details. Despite not loading the pretrained weights, there's something wrong about the makeup loss as my memory rewinds, a problem that I forgot to write down. I tackled the problem by visualizing the image results during and after Histogram matching. I bet you could solve the problem via visualizing intermediate results too.

Could you share the makeup loss after you fixed it? Actually, I visualized the image after Histogram matching and found the result which before and after histogram_matching was same! I am puzzled about it, do you have any ideas?

I made tons of modification locally. It's a little difficult for me to tell which modification solved the problem. Nonetheless, a cross comparison with the HEAD might point answer to line 26 and 29 in HistogramLoss class. You can try to remove the unsqueeze action in these two lines.

Solve it! Thanks a lot!

CelineWang1027 commented 3 years ago

solved.

zimenglan-sysu-512 commented 10 months ago

@CelineWang1027 how did u solve it?