search

wtnbass / fuco

Functional Component like React, but for Web Components.
MIT License
74 stars 2 forks source link

Fix to work well when remounting elements #20

Closed wtnbass closed 5 years ago

wtnbass commented 5 years ago

Description

useEffect does not work when remounted.

defineElement("effect-element", () => {
  useEffect(() => {
    console.log("mounted");
    return () => console.log("unmounted")
  }, []);
});

// On other element
html`
  ${cache(condition ? html`
    <effect-element></effect-element>
  ` : html``
  }
`
codecov-io commented 5 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   96.68%   96.73%   +0.04%     
==========================================
  Files           6        6              
  Lines         151      153       +2     
  Branches       25       25              
==========================================
+ Hits          146      148       +2     
  Misses          3        3              
  Partials        2        2
Impacted Files Coverage Δ
src/core/component.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd969a1...0387955. Read the comment docs.