wtsi-hgi / docker-proxify

Allows building and running docker container images from behind a corporate proxy
84 stars 16 forks source link

Why do you need docker inside docker ? #4

Closed defender closed 8 years ago

defender commented 9 years ago

Hi

First of all this is a great solution, my question is why do you need another instance of docker why cant you use external docker docker run -v /var/run/docker.sock:/var/run/docker.sock -v $(which docker):$(which docker) –v /lib64/libdevmapper.so.1.02:/lib/x86_64-linux-gnu/libdevmapper.so.1.02 -v /lib64/libudev.so.0.5.1:/lib/x86_64-linux-gnu/libudev.so.0.5.1 --privileged , this way you can

  1. Simplify your installtion
  2. You will be on the same page regarding versions of docker host & your solution
  3. You will remove unnecessary downloads of existing images on your instance and you will use parent docker images.

Thanks

wtsi-mercury commented 9 years ago

It seems like that might work, but I haven't tried it. I was following the pattern for docker-in-docker suggested by Jérôme Petazzoni (https://blog.docker.com/2013/09/docker-can-now-run-within-docker/), because I wanted to start from something known to work and then layer the transparent proxying on top of that. If you can get it to work without fully encapsulating the inner docker, that might be useful to some people - feel free to fork and modify!

jrandall commented 8 years ago

A few more things about docker-in-docker: