search

wtsi-hgi / hgi-systems

Orchestration and configuration management of hgi systems (using terraform & ansible)
GNU General Public License v3.0
3 stars 3 forks source link

`ansible-consul : consul config file` task is not idempotent #12

Closed colin-nolan closed 7 years ago

colin-nolan commented 7 years ago

Task path: /data/hgi-systems/subrepos/ansible-consul/tasks/install.yml:192

colin-nolan commented 7 years ago

Running a diff on the files before and after a change shows changes in the order of the "retry_join" values.

Before:

    "retry_join": [
        "192.168.102.51",
        "192.168.102.47"
    ],

After:

    "retry_join": [
        "192.168.102.47",
        "192.168.102.51"
    ],
colin-nolan commented 7 years ago

Needs a | sort here: https://github.com/wtsi-hgi/hgi-systems/blob/9c56d7f069496e61f173488449acbcb055db3f20/subrepos/ansible-consul/templates/consul.json.j2#L21

colin-nolan commented 7 years ago

Bug reported upstream: https://github.com/savagegus/ansible-consul/issues/197

colin-nolan commented 7 years ago

Pull request with fix pending: https://github.com/savagegus/ansible-consul/pull/198. Switched to using our fork to get the fix without waiting for the merge upstream.