Files Get At Least One Warning

[michael-grace]

See the message in Slack for what needs to be done after this and gn5's branches are merged.

Closes #31

Also, postgres functions aren't tested - this would involve setting up as postgres instance within the travis runner. But for now, it just says the coverage has decreased.

[pep8speaks]

Hello @michael-grace! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file api/persistence/engine.py:

Line 148:1: W293 blank line contains whitespace Line 184:1: W293 blank line contains whitespace Line 188:1: W293 blank line contains whitespace

• In the file bin/common.py:

Line 51:14: E231 missing whitespace after ':' Line 51:16: E251 unexpected spaces around keyword / parameter equals

• In the file bin/sandman/walk.py:

Line 179:27: E231 missing whitespace after ':' Line 179:29: E251 unexpected spaces around keyword / parameter equals

• In the file test/common.py:

Line 94:1: E303 too many blank lines (3)

Comment last updated at 2022-05-27 10:44:26 UTC

[michael-grace]

don't move file to limbo if no warning sent - send warning instead

[codecov[bot]]

Codecov Report

Merging #34 (97bda68) into develop (4bac31d) will increase coverage by 8.37%. The diff coverage is 96.87%.

:exclamation: Current head 97bda68 differs from pull request most recent head 3ad9ee4. Consider uploading reports for the commit 3ad9ee4 to get more accurate results

@@             Coverage Diff             @@
##           develop      #34      +/-   ##
===========================================
+ Coverage    82.65%   91.03%   +8.37%     
===========================================
  Files           34       35       +1     
  Lines         1949     2008      +59     
===========================================
+ Hits          1611     1828     +217     
+ Misses         338      180     -158     

Impacted Files	Coverage Δ
api/config.py	96.05% <ø> (ø)
core/persistence.py	96.73% <88.88%> (+15.40%)	:arrow_up:
bin/sandman/walk.py	74.52% <91.66%> (+0.49%)	:arrow_up:
api/persistence/common.py	100.00% <100.00%> (ø)
api/persistence/engine.py	89.83% <100.00%> (+62.05%)	:arrow_up:
api/persistence/models/collections.py	88.46% <100.00%> (+30.12%)	:arrow_up:
api/persistence/models/state.py	100.00% <100.00%> (+67.10%)	:arrow_up:
api/vault/file.py	96.39% <100.00%> (+1.61%)	:arrow_up:
bin/common.py	100.00% <100.00%> (ø)
bin/sandman/sweep.py	91.51% <100.00%> (+1.00%)	:arrow_up:
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c010fab...3ad9ee4. Read the comment docs.

[michael-grace]

writing some tests to test generating the SQL even if the DB connection isn't being tested