wtsi-hgi / irobot

iRODS data brokerage service
GNU General Public License v3.0
0 stars 0 forks source link

prefix data object URIs with something #11

Closed jrandall closed 7 years ago

jrandall commented 7 years ago

There are four main endpoints in iRobot:

Bissell currently blocks all data object paths starting with /status /config or /manifest (contrary to the clear documentation on that point) because it is an unusual thing to do and doesn't fit with the "router" syntaxes of any of the web server frameworks I'm familiar with. I'm sure I can fix it, though it would require some special handling and I'd prefer just to have the data objects prefixed with /data because that is much more clear and I cannot see any drawbacks of that approach.

Xophmeister commented 7 years ago

In the iRobot code, /status, /config and /manifest are hardcoded routes, with no parametrisation/wildcards, that appear first in the routing table. Then there's the catch all for data objects. If a data object is something like /status/my_data_object that won't be caught by the /status handler because it's not a match. iRODS can't have data objects at the root, so it will never be the case that /status is a valid data object.

jrandall commented 7 years ago

Oh actually the test I was running before was not quite right - bissell is handling things like /status/file.cram just fine. I'd still prefer being prefixed with /data but it isn't currently a problem for bissell.