wtsi-npg / bambi

Process Illumina instrument data into SAM/BAM/CRAM files.
http://wtsi-npg.github.io/bambi
GNU Affero General Public License v3.0
9 stars 15 forks source link

Handle NovaseqX output #184

Closed jenniferliddle closed 1 year ago

kjsanger commented 1 year ago

The sam file added to the test data doesn't look like plain text (is it compressed?), unlike previous sam files in the test data. Is that expected?

jenniferliddle commented 1 year ago

Yes, this is expected. There are other files with a .sam extension which are actually BAM files, so this isn't unique. It isn't ideal, but it's done that way for...errr...historical reasons.

dkj commented 1 year ago

I think we may be best to merge with 8ca1c87 now, and release. Then address improvements for read names and qualities for further work.

dkj commented 1 year ago

I think we may be best to merge with 8ca1c87 now, and release. Then address improvements for read names and qualities for further work.

This merge has been done.