wtsi-npg / baton

iRODS client programs and API
http://wtsi-npg.github.io/baton
GNU General Public License v2.0
19 stars 19 forks source link

Handle empty data object checksums #250

Closed kjsanger closed 3 years ago

kjsanger commented 3 years ago

A data object checksum can legitimately be null if a file has been put without the checksum option set E.g. This is the default behvaiour of iput to a vanilla server. We don't often see this in practice because we have a server-side rule to enforce checksum creation.

kjsanger commented 3 years ago

Supersedes #249

kjsanger commented 3 years ago

Test with no checksum in iRODS worth it?

That's a bit tricky - any such test would be fragile because getting an object without a checksum depends on server config. Tests would usually fail on our iRODS instances because they have a rule to create checksums by default, but pass on our Docker containers.