search

wtsi-npg / npg_id_generation

GNU General Public License v3.0
0 stars 5 forks source link

PacBioEntity is missing a constructor #18

Closed kjsanger closed 7 months ago

kjsanger commented 8 months ago

https://github.com/wtsi-npg/npg_id_generation/blob/b7a2da5629a9738c1aa533d2792b243fd014c9bd/npg_id_generation/pac_bio.py#L46

This class doesn't have a constructor, which makes creating one awkward and also means there's no docstring.

nerdstrike commented 7 months ago

PacBioEntity inherits a constructor from BaseModel and does not need one. Docstrings for pydantic classes are very much up for debate.