search

wtsi-npg / npg_ml_warehouse

Analysis results loader for the multi-lims warehouse, see ml_warehouse project for the warehouse details.
0 stars 13 forks source link

assessment is spelt incorrectly as "assessement" in DDL #200

Open kjsanger opened 2 years ago

kjsanger commented 2 years ago

This occurs in a both the DDL and code e.g. in IseqExternalProductMetric. Flagged by spell-checking in an IDE.

kjsanger commented 2 years ago

Other typos in comments:

delimited as "delimitered" unambiguously as "unambigiously" "exection" Instrument as "Instument"

mgcam commented 2 years ago

Why is this classified as a bug? Is there a failure anywhere in the process?

kjsanger commented 2 years ago

When I spelled it correctly in a query, I got an error about an unknown column. It isn't consistent across columns, so it's not just a case of consistently spelling it with an extra "e".

contamination_assessment,
overrepresented_sequences_assessement
dkj commented 2 years ago

There will be more risk/cost in fixing this than leaving it given the flag day required for a change, currently unknown downstream use and changes required, and limited lifetime (Jan/Feb 2022) of the associated project. Recommend we live with the bad column names until the table is deprecated at end of the project.