Closed ces closed 8 months ago
This is a suggestion to simplify/improve the code, not a comment on the lines that were edited/added.
The _build_run_wells method
in npg_warehouse::loader::pacbio::run
always returns a reference to an empty array, even when the condition on line https://github.com/wtsi-npg/npg_ml_warehouse/blob/0a3ccd996cdd873503534af6539b79474435a5a6/lib/npg_warehouse/loader/pacbio/run.pm#L160 is false. This might be clearer if the @run_wells
list on the previous line is explicitly initialised to an empty list.
Therefore on line 102 $self->product_data($well_data);
a defined value is always passed to the product_data
accessor,
which means that the ever growing and increasing in complexity product_data
method in npg_warehouse::loader::pacbio::product
can be simplified by dropping current lines 47 and 48 and a condition
if ($well_data) {
on line 53 .
Add product specific values for yield etc.