search

wtsi-npg / npg_ranger

NGS data streaming (sam, bam, cram, vcf) - pre-production
Other
4 stars 6 forks source link

Upgrade dependencies in package.json #239

Closed ghost closed 2 years ago

ghost commented 2 years ago

Upgrades all dependencies which pass CI on my fork without needing code changes.

238 would probably need to be merged first so CI can run here.

jmtcsngr commented 2 years ago

We were keeping track of dep updates in Changes file. Could you please take a look?

ghost commented 2 years ago

I'll update the Changes file. What seems odd is that one run failed here, but passed on my fork. I expect it should normally return the same result in both cases since I just rebased on devel. Maybe the timeout for the test is too small?

jmtcsngr commented 2 years ago

Thanks!

Re: failed tests, I saw that too. We may have a flaky test, or something new was introduced by the dep change. I saw we note the tests failing and keep dev. If we see it happen again we check the test. We need to check the tests you disabled anyway. Sounds good? I will merge if you agree, but happy for you to spend some time checking that specific test if you want to dig into it for a bit.

ghost commented 2 years ago

Agreed, I think you can merge.