search

wtsi-npg / sqyrrl

Sqyrrl - an HTTP server for files hosted in iRODS
GNU General Public License v3.0
0 stars 4 forks source link

Deploy on Alpine and add a non-root user #13

Closed kjsanger closed 7 months ago

kjsanger commented 7 months ago

Fix setting version string in the built application

kjsanger commented 7 months ago

Using make to call git inside the container feels strange. Passing things through variables may be better. As it is now, it works. So we could create an issue to improve later if you think it is reasonable.

Then we'd have two different build commands, one building in the container and one for outside (the Makefile). We don't worry about copying bash scripts into containers to run them (it's an accepted way of avoiding hairy RUN commands), so I don't think we should worry about Makefiles (especially as make is provided by the container).

jmtcsngr commented 7 months ago

I found it unusual to mount .git in container build to resolve the version. Also had issues executing tests with make so I think there will be more work on the Makefile anyway. I had to check how things were working in actions to figure out how to do things locally.

kjsanger commented 7 months ago

The container doesn't install the test dependencies - it's purely for building after the tests have been run by the test workflow. The test framework is installed for the tests here https://github.com/wtsi-npg/sqyrrl/blob/404291adcb3bb86c56a91bcee71e1693de7bda47/.github/workflows/run-tests.yml#L59