wtsnjp / llmk

Light LaTeX Make
https://ctan.org/pkg/llmk
MIT License
110 stars 5 forks source link

Feature/clean cmd #5

Closed hidaruma closed 5 years ago

hidaruma commented 5 years ago

I added the functions -c(--clean) and -C(--clobber) cf. #4 . Unfortunately, I couldn't code rake test the functions because of my lack of rake's way.

And moved check_filename function in runner to in util.

-c removes files in array of clean_files, and -C removes in clobber_files.

In default, clean_files has

clobber_files has

wtsnjp commented 5 years ago

Thank you for pull requesting a nice feature! I really appreciate your contribution.

Unfortunately, I couldn't code rake test the functions because of my lack of rake's way.

That's ok. I will write some tests for the feature later.

-C removes in clobber_files

Just to confirm: the clobber action (-C, --clobber) removes all files specified in clean_files and clobber_files, right?

The default settings for clean_files and clobber_files looks reasonable to me. Great.

hidaruma commented 5 years ago

Just to confirm: the clobber action (-C, --clobber) removes all files specified in clean_files and clobber_files, right?

Oh, that's right. -C removes files in clean_files first, and removes in clobber_files .

wtsnjp commented 5 years ago
  • del_dir : is string value. If set a diectory path to here, -c and -C options move the files into the directory set.

Oh, an explanation for del_dir remains in the README.md, but this feature is actually not implemented, right? If so, I will delete the line.

cf. https://github.com/wtsnjp/llmk/blame/a5aa3e543de1c901547ae81fb7255252128d3f50/README.md#L60-L63

hidaruma commented 5 years ago

Oops. I'm sorry, I had forgot to delete the line del_dir . It is no problem that you delete the line.

Oh, an explanation for del_dir remains in the README.md, but this feature is actually not implemented, right? If so, I will delete the line.

wtsnjp commented 5 years ago

Ok, I will take care of it. Thanks again :)