search

wtsnz / Coordinator-Example

An example of the Coordinator pattern
169 stars 31 forks source link

Migrate to Swift 5 and iOS 13 #7

Open alekplay opened 4 years ago

alekplay commented 4 years ago

This PR migrates the Xcode project to Swift 5.0, one of two major versions of Swift supported by Xcode 11, and is needed to make the project compile and run if downloaded (fixes #5).

This PR also sets the modal presentation style of the new order coordinator's root controller to fullScreen which is needed to trigger viewWillAppear of the underlaying splash view controller, which in turn updates the total number of orders. This is because the default modal presentation style changed in iOS 13 to pageSheet (fixes #6).

Finally it updates the readme to accurately reflect the required Xcode and Swift versions