No guava dependencies - Githubissues

wttech / AEM-Rules-for-SonarQube

SonarQube plugin with set of rules detecting possible bugs and bad smells specific for AEM development.

Apache License 2.0

112 stars 51 forks source link

No guava dependencies #197

Closed pun-ky closed 4 years ago

pun-ky commented 4 years ago

This is an attempt for eliminating Guava related runtime errors like in #190

Improved 2 things:

removed direct dependency to guava 28-jre which is the even higher version than the most recent version of sonar-java-plugin -26-jre
removed all Guava usages from code, no imports to classes com.google.*

Regardless Guava version provided by Sonar, our plugin should work fine.

toniedzwiedz commented 4 years ago

@pun-ky I've got #196 to build. Once those changes are merged to master and re-integrated into this branch, the build should pass just fine.

coveralls commented 4 years ago

Coverage decreased (-0.5%) to 95.574% when pulling 449927a17468ba8aa3bbeebd66f4bc1d9c785c4e on no-guava into a4e6d6c21a76f4487bffee5152698cc32ba524de on master.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
4 Code Smells

96.0% Coverage
0.0% Duplication

toniedzwiedz commented 4 years ago

Tested the new version with Docker images of SonarQube 7.9.3 and 8.3.0. The exceptions mentioned in https://github.com/Cognifide/AEM-Rules-for-SonarQube/issues/198 and https://github.com/Cognifide/AEM-Rules-for-SonarQube/issues/190 no longer occur. SonarQube starts up successfully.

toniedzwiedz commented 4 years ago

Should also take care of https://github.com/Cognifide/AEM-Rules-for-SonarQube/issues/199