search

wttech / AEM-Rules-for-SonarQube

SonarQube plugin with set of rules detecting possible bugs and bad smells specific for AEM development.
Apache License 2.0
112 stars 51 forks source link

AEM Rules binary name needs to be updated manually after each release #225

Closed toniedzwiedz closed 2 years ago

toniedzwiedz commented 2 years ago

The GitHub workflow used to automate plugin installation as part of tests currently uses hardcoded values for the JAR name https://github.com/wttech/AEM-Rules-for-SonarQube/blob/master/.github/workflows/test-instalation.yml#L44

Replace this with something dynamic so that the script can be the same regardless of the branch and doesn't have to be updated.

This is especially annoying when using the Maven Release Plugin's release:prepare and release:perform goals which update the pom versions, but not the workflow file.

toniedzwiedz commented 2 years ago

Fixed in https://github.com/wttech/AEM-Rules-for-SonarQube/pull/226