wttech / aet

AET - a system that detects visual changes on web sites and performs basic page health checks
https://wttech.blog/open-source/
Apache License 2.0
142 stars 47 forks source link

Research a tool that will validate code quality at GitHub #13

Open malaskowski opened 7 years ago

malaskowski commented 7 years ago

Research a tool that will validate code quality on GitHub and apply it as a PoC on existing AET GitHub repo, then integrate it with current codebase and check it (no fixes are in scope of this task).

wiiitek commented 7 years ago

We may use SonarQube.com for that purpose. See pull request https://github.com/Cognifide/aet/pull/33

wiiitek commented 7 years ago

Done some investigation around usage of Sonarqube.com. As long as those improvements are upcoming;

we could use some additional artificial user for internal pull request analysis. The account which would add comments about Sonarqube violations.

This user needs to have following permissions:

chutch commented 7 years ago

It's already set up on AEM Rules plugin. Drop me a line in case of any questions. https://sonarqube.com/dashboard?id=com.cognifide.aemrules%3Aaemrules https://github.com/Cognifide/AEM-Rules-for-SonarQube

wiiitek commented 7 years ago

I have also prepared some config for checking feature branches waiting for merge. See: https://github.com/orrrg/test/blob/master/.travis.yml