wttech / aet

AET - a system that detects visual changes on web sites and performs basic page health checks
https://wttech.blog/open-source/
Apache License 2.0
146 stars 49 forks source link

Quarantine feature for AET #258

Open szymon-owczarzak opened 6 years ago

szymon-owczarzak commented 6 years ago

Version used

Context of the issue/feature

We use AET a lot in our project. We often come to a situation when there is a unwanted change visible in our suite and we know that it will be fixed in near future. In this case we neither want to accept this change nor be bothered by it every day until it is fixed. For this kind issues that are valid by will be fixed in future we need a quarantine feature.

Feature description

After discussion that took place on 11th of May 2018 by @Skejven @wiiitek @szymon-owczarzak we came up with this ideas:

Indication of elements that are in quarantine:

Suite level:

Additional notes

toniedzwiedz commented 6 years ago

Sounds like a very useful feature. I'd love to be able to use it on my project.

radeklawgmin commented 6 years ago

What about the case when:

Are we able to make the first change (the one that had been spotted before the user made use of the Quatantine feature) a kind of 'sub-pattern' or 'Quatantine pattern' with some threshold so that the user is alerted once the other change departing from the standard defined by her/him in the threshold for this case appears on the page?

mchrominski commented 6 years ago

I believe this should be achievable by storing the quarantined pattern but I suggest dropping this requirement for two reasons: