wttech / aet

AET - a system that detects visual changes on web sites and performs basic page health checks
https://wttech.blog/open-source/
Apache License 2.0
145 stars 49 forks source link

Note after re-run doesn't exist. #443

Closed Slasheruus closed 4 years ago

Slasheruus commented 5 years ago

There are 4 levels of notes. 1(suite level) - it works properly. 2(test level) - it works properly. 3(url level) - it works properly. 4(case level) - after re-run the note disappears.

To Reproduce Steps to reproduce the behavior: 1.Add note on each level.

  1. Save the changes 3.Re-run the same suite and open the newest report.
  2. There are no note on the level 4

Expected behavior There are note on the level 4

malaskowski commented 5 years ago

There is one more level - case level which was not working properly and fixed in #363 .

Slasheruus commented 5 years ago

Thanks for this info. I edited bug description.

wblachowski commented 5 years ago

Can't reproduce this bug with AET 3.2.0 and changes from PR #363 (not merged to master yet).

radeklawgmin commented 5 years ago

The issue still exists on the test case level in the version 3.2.2. To reproduce:

  1. add a note to the test case level
  2. click the update button
  3. Reload the report or go to some url or other report lever and get back to the same test case.
Cich0sza commented 5 years ago

Can't reproduce this bug in the current version of AET. Maybe it's related with specific suite configuration.

radeklawgmin commented 4 years ago

Looks like the issue no longer exists.

annabudziszewska commented 4 years ago

Tested and accepted Separate issue concerning notes has been reported: https://github.com/Cognifide/aet/issues/584