search

wttech / aet

AET - a system that detects visual changes on web sites and performs basic page health checks
https://wttech.blog/open-source/
Apache License 2.0
145 stars 49 forks source link

No red highlight for too big asset in request monitoring #602

Open basia-wulnikowska opened 3 years ago

basia-wulnikowska commented 3 years ago

Describe the bug In new feature request monitoring, we've got option to choose max size of assets and if they're bigger - they are listed with some highlight. Currently there is no red highlight for biggest asset that is too big. Check screenshot (first file is too big here).

2020-11-24_13h55_41
basia-wulnikowska commented 3 years ago

IMPORTANT: After discussion we understood, that currently request monitoring only checks all assets total size and is basing on it. We agreed that checking max size for each specific item would also be good improvement for this feature. Additional code is being added to request monitoring. When functionality of checking maxSize for items will be implemented on backend, we only need to uncomment the code and this should work.