search

wttech / gradle-aem-plugin

Swiss army knife for Adobe Experience Manager related automation. Environment setup & incremental AEM application build which takes seconds, not minutes.
https://tech.cognifide.com/tag/gradle-aem-plugin
Apache License 2.0
157 stars 32 forks source link

Too specific front-end ignoredFiles defaults #23

Closed mateuszluczak closed 7 years ago

mateuszluczak commented 7 years ago

Currently contentIgnoreFiles default configuration contains 3 front-end related entries:

            "**/package.json", // 1)
            "**/clientlibs/Gruntfile.js", // 2)
            "**/node_modules/**",

node_modules is fine as I cannot imagine situation where you would like to have it on instance however I have problem with 1) and 2).

Regarding 1)

When working with tools like aem-sync front-end developers should be able to export CRX package and work directly on it. It's not possible without package.json to install required dependencies.

Regarding 2)

This seems super specific - Grunt is one of many front-end development tools (Gulp, Webpack, Brunch, Rollup - there are tons and tons of them). Also Gruntfile can be present on any level under clientlibs, this path is very specific. The same idea as for 1) applies here, Gruntfile may be required when working with aem-sync.

I would suggest removing this entries from default configuration.

pun-ky commented 7 years ago

Thank you very much for reporting this. Both will ne removed in next version.

pun-ky commented 7 years ago

improved as suggested. thank you very much

https://github.com/Cognifide/gradle-aem-plugin/blob/master/src/main/kotlin/com/cognifide/gradle/aem/AemConfig.kt#L87