wub / preact-cli-plugin-typescript

Adds TypeScript support to preact-cli :zap:
MIT License
49 stars 6 forks source link

Support newest version of TypeScript #9

Open KasparEtter opened 6 years ago

KasparEtter commented 6 years ago

Hi, is my understanding correct that the TypeScript dependency of this package should be updated if I want to use a newer version of TypeScript? If yes, could you do so? Thanks in advance!

KasparEtter commented 6 years ago

Sorry, I just realized that it is taking the newest version already: https://github.com/wub/preact-cli-plugin-typescript/blob/master/package.json#L24. Feel free to close this issue. I guess I have to find the problem in my setup elsewhere…

SleeplessByte commented 6 years ago

The newest is actually 3.0.3 (at moment of commenting).

SleeplessByte commented 6 years ago

Why is this closed?

On Thu, 20 Sep 2018, 10:52 Kaspar Etter, notifications@github.com wrote:

Closed #9 https://github.com/wub/preact-cli-plugin-typescript/issues/9.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wub/preact-cli-plugin-typescript/issues/9#event-1857068424, or mute the thread https://github.com/notifications/unsubscribe-auth/AB35WB0Gzrg-b0dLwZVOweBT81erIRpQks5uc1dmgaJpZM4Wdrbe .

KasparEtter commented 6 years ago

I closed it because – at least according to my understanding – the caret already ensures that the newest version is taken. It was my mistake to open this non-issue in the first place. If you think I'm wrong and the version should indeed be changed, please reopen the issue. https://github.com/wub/preact-cli-plugin-typescript/blob/49487ea6341223e1d2703b69a8cc4ffc86e0828b/package.json#L24

SleeplessByte commented 6 years ago

The caret ensures that the last patch increase is taken, given major.minor.patch (or better yet, it will allow for an increase of the last component of the version), so in this case it will never get to the current version of 3.0.3.

^2 is similar to >= 2.0.0 ^2.0 is similar to >= 2.0.0, < 3 ^2.0.0 is similar to >= 2.0.0, < 2.1.0

KasparEtter commented 6 years ago

Thanks, good to know! Then, I guess, we should reopen this issue!