search

wubostc / virtualized-table-for-antd

the virtualized table component for ant design
MIT License
230 stars 48 forks source link

Use Map to store records indexes #132

Closed Vincz closed 1 year ago

Vincz commented 1 year ago

It's an attempt to solve https://github.com/wubostc/virtualized-table-for-antd/issues/120 Tested it with a couple of projects using the component but I haven't been able to run the tests from the test directory. The idea is to store the records indexes in a Map() created in the context.

wubostc commented 1 year ago

Cool! It would be better to use WeakMap instead of Map,right?

Vincz commented 1 year ago

@wubostc yes, you are right about WeakMap. Just updated my PR. Are you able to launch the tests on your side to check if everything is ok and it doesn't break anything?

Vincz commented 1 year ago

Awesome. Thank you @wubostc. Do you mind to publish a new version?