wufe / react-particles-js

Particles.js for React
https://rpj.bembi.dev/
MIT License
1.15k stars 108 forks source link

Does not use passive listeners to improve scrolling performance #117

Closed M-Fasciano closed 4 years ago

M-Fasciano commented 4 years ago

Hi Simone,

I'm using React Particles in my portfolio and works great, thank you.

The only issue I've found is when I run Lighthouse from Google.

The error says Does not use passive listeners to improve scrolling performance.

Hope you can help.

matteobruni commented 4 years ago

Hi @M-Fasciano,

Thanks for the report, I've opened an issue in tsParticles about this warning and it will be released a fix in the next version this weekend.

M-Fasciano commented 4 years ago

Hi @M-Fasciano,

Thanks for the report, I've opened an issue in tsParticles about this warning and it will be released a fix in the next version this weekend.

Hi @matteobruni ,

I've tested your demo in chrome and still can see the issue I've mentioned above.

Thank you Michele

matteobruni commented 4 years ago

Hi @M-Fasciano, do you use any additional extension?

I've double checked now and chrome doesn't gives any warning like that

M-Fasciano commented 4 years ago

Hi @M-Fasciano, do you use any additional extension?

I've double checked now and chrome doesn't gives any warning like that

Hi @matteobruni,

Maybe I wasn't clear enough when I've opened the issue. Basically, if you open Chrome inspector there is a tab called Audits, if you press it then you will see another button "Generate report". Once the report is done you will see the error under the best practices section. I've attached a screenshot. Let me know if you need more information.

Screenshot 2020-04-25 at 11 29 04

This is what google devs suggest as a fix. https://web.dev/uses-passive-event-listeners/?utm_source=lighthouse&utm_medium=devtools

Thank you Michele

matteobruni commented 4 years ago

Ok I've found the report you're talking about. I've checked my demo site and that practice is ok, when did you checked? I've updated the demo website tonight (CEST TZ).

I've seen your GH page repository and it uses react-particles-js 3.0.3, can you try upgrade to 3.1.0 and installing tsParticles version to 1.13.0 to override the 1.12.11 dependency? 1.13.0 version should fix that issue.

M-Fasciano commented 4 years ago

Ok I've found the report you're talking about. I've checked my demo site and that practice is ok, when did you checked? I've updated the demo website tonight (CEST TZ).

I've seen your GH page repository and it uses react-particles-js 3.0.3, can you try upgrade to 3.1.0 and installing tsParticles version to 1.13.0 to override the 1.12.11 dependency? 1.13.0 version should fix that issue.

Hi @matteobruni,

I've just generated a report of your demo and this is the result. As you can see from the screenshot the issue is still there.

Screenshot 2020-04-25 at 12 39 51
matteobruni commented 4 years ago

I think it's an extension you have installed that gives the issue.

I'll attach you screenshots of my Chrome, it's a clean install because I don't use it.

Schermata 2020-04-25 alle 13 47 05 Schermata 2020-04-25 alle 13 46 19

Can you try checking if Chrome gives you the warning with all extensions disabled?

M-Fasciano commented 4 years ago

Ok I've found the report you're talking about. I've checked my demo site and that practice is ok, when did you checked? I've updated the demo website tonight (CEST TZ).

I've seen your GH page repository and it uses react-particles-js 3.0.3, can you try upgrade to 3.1.0 and installing tsParticles version to 1.13.0 to override the 1.12.11 dependency? 1.13.0 version should fix that issue.

Hi @matteobruni,

I'll try to do what you have suggested and let you know.

M-Fasciano commented 4 years ago

Hi @matteobruni,

I've updated Particles.js and installed tsParticles, tested in chrome incognito and everything seems to work fine. The error is not related to Particles.js but to a chrome extension called ng-inspector. Thanks for your time :pray: