search

wufe / react-particles-js

Particles.js for React
https://rpj.bembi.dev/
MIT License
1.16k stars 106 forks source link

example with: 1. remove params from render function(best practice 2. … #5

Closed stavros-liaskos closed 7 years ago

stavros-liaskos commented 7 years ago

…show json format usage 3. show createClass usage

wufe commented 7 years ago

Sorry for the late answer, but I have been busy. I'm sorry, but I have to deny your PR because it doesn't seem consistent:

  1. Yeah, removing params from the render function is a way to keep the code readable, but it is not necessary in an example.
  2. The json includes the js syntax itself: it is basically the same. So it is not necessary to write it down.
  3. It is also not necessary to show createClass, because it is always the same syntax when transpiling from JSX to JS.

Please feel free to make your point if you don't agree. Thanks for your contribute.